[Maps] Move layers to np maps #61877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindsun
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
There was a problem hiding this comment.
Thanks for moving! 💦
In general, I think we should strive for as clean a move as possible. It's easier to follow along when the dependencies are legacy->np instead of the other way around. NP is more&more becoming the source-of-truth (especially for utils/configs), so it's iffy referencing from np to legacy when it's not strictly necessary.
- There's some unnecessary dependencies from NP to legacy. Instead of referencing legacy, these should reference the original NP-equivalent.
- `constants
kibana_servicesi18n_getters
- While it may be "technically" allowed, I would already start moving legacy module dependencies wholesale, especially the fairly dummy config and utility ones. I don't think there's a particular reason to keep them hanging around in legacy, when we can just move them wholesale right now.
legacy/maps/common/descriptor_types: (it pretty much defines thelayers/*data-model).elasticsearch_geo_utilsconnected_components/map/mb_utils(this one actually has atodoanyway).
- I'd move over some of the stray utility-functions to NP already (the other utilities can stay in legacy, but just lift out the simple ones).
isRetinafrommeta.
I think I caught most of them. There's a few react-components, and utilities relying on chrome which we can keep in legacy in the short-term.
x-pack/plugins/maps/public/layers/sources/ems_unavailable_message.js
Outdated
Show resolved
Hide resolved
|
Thanks @thomasneirynck. There are several paths that got updated to pull from legacy. I expected this, but usually these get flagged in subsequent linting. It's not at all clear to me why that's not happening here. To resolve these issues and to address the remainder of your comments, I'll need to import a few layers-adjacent files. I'll re-request review when I've completed this work! |
snide
approved these changes
Mar 30, 2020
added 5 commits
March 31, 2020 14:09
added 8 commits
April 1, 2020 12:08
|
@thomasneirynck @nreese This should be ready for another pass. For the most part, this PR still amounts largely to just moving the layers files to NP, but with a couple of updates:
|
nreese
approved these changes
Apr 6, 2020
thomasneirynck
approved these changes
Apr 6, 2020
| @@ -3,7 +3,89 @@ | |||
| * or more contributor license agreements. Licensed under the Elastic License; | |||
| * you may not use this file except in compliance with the Elastic License. | |||
| */ | |||
| import { esFilters, search } from '../../../../src/plugins/data/public'; | |||
There was a problem hiding this comment.
great to see so many functions moved over
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Apr 6, 2020
* Move layers to new location * Update layer path refs * Update np kibana services to cover all required services * Init np kibana services in legacy plugin. Port init functions to np * Path updates, supporting file moves, general clean up * More moves of related files and clean-up of legacy refs * Path updates. Typescript warning fixes * Update test paths * Clean up unused kibana services usage in legacy * Remove unused http ref * Test fixes and clean up * Remove unused snapshots * Add np service init to embeddables too * Move validate color picker to NP
kindsun
pushed a commit
that referenced
this pull request
Apr 6, 2020
* Move layers to new location * Update layer path refs * Update np kibana services to cover all required services * Init np kibana services in legacy plugin. Port init functions to np * Path updates, supporting file moves, general clean up * More moves of related files and clean-up of legacy refs * Path updates. Typescript warning fixes * Update test paths * Clean up unused kibana services usage in legacy * Remove unused http ref * Test fixes and clean up * Remove unused snapshots * Add np service init to embeddables too * Move validate color picker to NP
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 7, 2020
* master: (36 commits) [data.search.aggs] Remove service getters from agg types (elastic#61628) fixing APM internationalization (elastic#62757) fix: 🐛 correctly create error on no_matching_indices (elastic#61257) [Lens] Remove all legacy imports (elastic#62596) Add label for ace editor (elastic#62588) [ML] Show better file structure finder explanations (elastic#62316) Fix old pathes in eslintrc (elastic#62580) [Uptime] Improve Telemetry test (elastic#62428) [SIEM] Adds sort rules Cypress test (elastic#62700) [Uptime]Abstracted 'access:uptime-read' tag into a wrapper for… (elastic#62576) fixing bug (elastic#62577) [Maps] Allow updating requestType for ESGeoGridSource (elastic#62365) [Maps] do not show circle border when symbol size is zero (elastic#62644) [Maps] Always show current zoom level (elastic#62684) bc5 siem rules merge (elastic#62679) Revert "[Monitoring] Cluster state watch to Kibana alerting (elastic#61685)" Fix visual tests (elastic#62660) [Telemetry] update crypto packages (elastic#62469) [DOCS] Removed references to left (elastic#60807) [Maps] Move layers to np maps (elastic#61877) ...
11 tasks
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #59585. This PR moves layers to NP. For the most part, it really is just physically moving these files and updating refs to the files